Skip to content

remove extra std::forward in fwd/functor/reduce_sum loop#3323

Merged
SteveBronder merged 4 commits into
developfrom
fix/3303-reduce-sum
Jun 1, 2026
Merged

remove extra std::forward in fwd/functor/reduce_sum loop#3323
SteveBronder merged 4 commits into
developfrom
fix/3303-reduce-sum

Conversation

@SteveBronder
Copy link
Copy Markdown
Collaborator

@SteveBronder SteveBronder commented May 12, 2026

Summary

Fixes #3303 by removing extra std::forward in fwd/functor/reduce_sum.hpp

Tests

No new tests. I think this is a pretty reasonable potential bug that is just an extra forward reference in a loop.

Checklist

  • Copyright holder: Steve Bronder

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)

  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

syclik
syclik previously approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@syclik syclik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stan-buildbot
Copy link
Copy Markdown
Contributor

stan-buildbot commented May 13, 2026

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_regr/gp_regr.stan 0.1 0.1 1.0 -0.17% slower
gp_regr/gen_gp_data.stan 0.03 0.02 1.02 1.5% faster
arK/arK.stan 1.86 1.8 1.03 3.38% faster
eight_schools/eight_schools.stan 0.06 0.06 1.04 4.21% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.14 8.82 1.04 3.52% faster
pkpd/one_comp_mm_elim_abs.stan 20.47 20.75 0.99 -1.38% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.26 0.25 1.04 3.4% faster
sir/sir.stan 75.55 70.76 1.07 6.34% faster
gp_pois_regr/gp_pois_regr.stan 3.12 2.86 1.09 8.06% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.83 2.68 1.05 5.09% faster
irt_2pl/irt_2pl.stan 4.78 4.15 1.15 13.33% faster
arma/arma.stan 0.36 0.29 1.27 21.18% faster
garch/garch.stan 0.53 0.42 1.26 20.83% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 1.16 13.47% faster
performance.compilation 231.08 233.39 0.99 -1.0% slower
Mean result: 1.079391880579506

Jenkins Console Log
Blue Ocean
Commit hash: 7a7d72e615616c0f3361edc354f888fe5bb9b0d9

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Vmscape: Mitigation; IBPB before exit to userspace
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@SteveBronder
Copy link
Copy Markdown
Collaborator Author

SteveBronder commented May 19, 2026

@syclik can you reapprove?

syclik
syclik approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@syclik syclik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Moved the temp outside the loop as the last change. Approved.

@SteveBronder SteveBronder merged commit 58feca3 into develop Jun 1, 2026
34 checks passed
@drezap
Copy link
Copy Markdown
Contributor

drezap commented Jun 1, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syclik syclik syclik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reduce_sum: std::forward in fwd Loop Moves Shared Args

4 participants

@SteveBronder @stan-buildbot @drezap @syclik